Fix and improve paths and edit tool responses #774
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tell which file was deleted, and if possible, its size
…g textdoc tools if tools_failed: true
…e robust in Windows
…dirs or config folder
…f project folders, and properly resolve relative-ish paths
…used to resolve paths
| @@ -322,7 +324,9 @@ describe("ComboBox", () => { | |||
| const { user, ...app } = render(<App />); | |||
| const textarea = app.getByRole("combobox"); | |||
| await user.type(textarea, "@fi{Enter}"); | |||
| expect(textarea.textContent).toEqual("@file "); | |||
| await waitFor(() => { | |||
There was a problem hiding this comment.
It could be posable this was failing locally due to msw proxying the local sp, either way waitFor is a good addition since it's a network call
MarcMcIntosh
approved these changes
May 15, 2025
… vanishing on chats from current stable release
JegernOUTT
approved these changes
May 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.