Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Environment seperation cleanup, subscription API #53

Merged
merged 7 commits into from
Mar 27, 2023
Merged

Environment seperation cleanup, subscription API #53

merged 7 commits into from
Mar 27, 2023

Conversation

dogversioning
Copy link
Contributor

This PR makes the following changes:

  • Some cleanup work related to environment seperation
    • API lookup in test upload modified
    • Created environment specific workgroups
  • Parquet-related adjustments to dashboard queries now that actually have real null values
  • Added an API endpoint for retrieving the subscriptions available in Athena
  • Some preliminary work about mocking out Athena
    • This feels a bit premature - the awswrangler/moto crossover is not well tested, but we might be able to more precisely mock it out
    • This requires pegging the python version to 3.10 since that's as far as moto support goes
  • Added pyproject.toml & .python-version in support of unit testing locally inside a venv

I should've split this into two PRs! Sorry about the density.

@dogversioning dogversioning requested a review from mikix March 24, 2023 19:40
mikix
mikix reviewed Mar 27, 2023
View reviewed changes
.python-version Outdated Show resolved Hide resolved
pyproject.toml Show resolved Hide resolved
pyproject.toml Show resolved Hide resolved
pyproject.toml Outdated Show resolved Hide resolved
pyproject.toml Show resolved Hide resolved
template.yaml Show resolved Hide resolved
tests/dashboard/test_get_subscriptions.py Outdated Show resolved Hide resolved
src/handlers/dashboard/get_subscriptions.py Outdated Show resolved Hide resolved
src/handlers/dashboard/get_subscriptions.py Outdated Show resolved Hide resolved
src/handlers/dashboard/get_subscriptions.py Show resolved Hide resolved
mikix
mikix approved these changes Mar 27, 2023
View reviewed changes
Copy link
Contributor

@mikix mikix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think any of my remaining comments is blocker stuff. I'll approve to get out of your way, though I know you are fixing up some code comments and such still.

@dogversioning dogversioning merged commit fe8408b into main Mar 27, 2023
@dogversioning dogversioning mentioned this pull request Mar 29, 2023
Closed
@dogversioning dogversioning deleted the mg/subscription_api branch February 13, 2024 20:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mikix mikix mikix approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dogversioning @mikix