Disambiguate generics with unknown parametric assignments #492
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pyright's strict mode is becoming increasingly strict with regards to generics. You used to be able to effectively narrow them by declaring the type like so: string_list: list[str] = list() But that's no longer accepted. Now the actual value must itself resolve to something that has resolved parameterization. This unfortunately means that actual casting is sometimes necessary. It's not a huge hit because it's a do-nothing function, but it's still a function call that I'd rather not be doing.
JordonPhillips
force-pushed
the
update-deps
branch
from
8b7dcbd to
3ac5325
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pyright's strict mode is becoming increasingly strict with regards to generics. You used to be able to effectively narrow them by declaring the type like so:
But that's no longer accepted. Now the actual value must itself resolve to something that has resolved parameterization. This unfortunately means that actual casting is sometimes necessary. It's not a huge hit because it's a do-nothing function, but it's still a function call that I'd rather not be doing.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.