Exposes tokio guard API (Fixes #34) #39
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
notgull
requested changes
Mar 8, 2025
src/lib.rs
Outdated
| /// provides. | ||
| /// | ||
| /// TODO: Examples | ||
| pub fn enter_tokio_runtime() -> EnterGuard<'static> { |
There was a problem hiding this comment.
Please make this wrap a newtype around EnterGuard, I don't want to directly expose the tokio dependency.
There was a problem hiding this comment.
I see that the way entering tokio runtimes works has been changed. Would it be better if this public function entered the runtime for you or would it be better to make a wrapper of get_runtime_handle which returns a newtype and requires the user to call enter on it?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a new function which wraps
TOKIO1.handle.enter()and fixes #34I'm not quite sure how to write a good example for its documentation though.