Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump MSRV to 1.63 #45

Merged
merged 2 commits into from
Jun 11, 2023
Merged

Bump MSRV to 1.63 #45

merged 2 commits into from
Jun 11, 2023

Commits on Jun 11, 2023

  1. Bump MSRV to 1.63

    taiki-e committed Jun 11, 2023
    Configuration menu
    Copy the full SHA
    8a1e590 View commit details
    Browse the repository at this point in the history
  2. Fix clippy::needless_borrow warning

    ```
    error: the borrowed expression implements the required traits
       --> src/lib.rs:212:57
        |
    212 |                     signal_hook::iterator::Signals::new(&[signal_hook::consts::SIGCHLD])
        |                                                         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `[signal_hook::consts::SIGCHLD]`
        |
        = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
        = note: `-D clippy::needless-borrow` implied by `-D warnings`
    
    error: the borrowed expression implements the required traits
      --> tests/std.rs:14:38
       |
    14 |             Command::new("cmd").args(&["/C", "exit 0"]).spawn()
       |                                      ^^^^^^^^^^^^^^^^^ help: change this to: `["/C", "exit 0"]`
       |
       = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
       = note: `-D clippy::needless-borrow` implied by `-D warnings`
    
    error: the borrowed expression implements the required traits
      --> tests/std.rs:35:38
       |
    35 |             Command::new("cmd").args(&["/C", "exit 1"]).spawn()
       |                                      ^^^^^^^^^^^^^^^^^ help: change this to: `["/C", "exit 1"]`
       |
       = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
    
    error: the borrowed expression implements the required traits
      --> tests/std.rs:87:22
       |
    87 |             cmd.args(&["/C", "echo foobar"]).stdout(Stdio::piped());
       |                      ^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `["/C", "echo foobar"]`
       |
       = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
    
    error: the borrowed expression implements the required traits
       --> tests/std.rs:145:23
        |
    145 |                 .args(&["/C", "exit 1"])
        |                       ^^^^^^^^^^^^^^^^^ help: change this to: `["/C", "exit 1"]`
        |
        = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
    
    error: the borrowed expression implements the required traits
       --> tests/std.rs:156:23
        |
    156 |                 .args(&["/C", "exit 0"])
        |                       ^^^^^^^^^^^^^^^^^ help: change this to: `["/C", "exit 0"]`
        |
        = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
    
    error: the borrowed expression implements the required traits
       --> tests/std.rs:189:23
        |
    189 |                 .args(&["/C", "echo hello"])
        |                       ^^^^^^^^^^^^^^^^^^^^^ help: change this to: `["/C", "echo hello"]`
        |
        = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
    
    error: the borrowed expression implements the required traits
       --> tests/std.rs:213:23
        |
    213 |                 .args(&["/C", "mkdir ."])
        |                       ^^^^^^^^^^^^^^^^^^ help: change this to: `["/C", "mkdir ."]`
        |
        = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
    
    error: the borrowed expression implements the required traits
       --> tests/std.rs:231:38
        |
    231 |             Command::new("cmd").args(&["/C", "exit 1"]).spawn().unwrap()
        |                                      ^^^^^^^^^^^^^^^^^ help: change this to: `["/C", "exit 1"]`
        |
        = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
    
    error: the borrowed expression implements the required traits
       --> tests/std.rs:243:38
        |
    243 |             Command::new("cmd").args(&["/C", "exit 1"]).spawn().unwrap()
        |                                      ^^^^^^^^^^^^^^^^^ help: change this to: `["/C", "exit 1"]`
        |
        = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
    
    error: the borrowed expression implements the required traits
       --> tests/std.rs:257:23
        |
    257 |                 .args(&["/C", "echo hello"])
        |                       ^^^^^^^^^^^^^^^^^^^^^ help: change this to: `["/C", "echo hello"]`
        |
        = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
    ```
    taiki-e committed Jun 11, 2023
    Configuration menu
    Copy the full SHA
    a715640 View commit details
    Browse the repository at this point in the history