You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
My main complaint with the polling API is the fact that it doesn't expose sys::Events; instead, it reads events from the sys::Events into a Vec<Event>. In practice, this usually means that:
Steps 1 and 2 are necessary, but steps 3 and 4 feel unnecessary. It would be nice if the Events structure was exposed and given a real API. Is there any particular reason why polling was designed to use Vec<Event> in the first place?
This would be a breaking change, but there's already breaking changes on the horizon (#38) so we should probably at least plan for this.
The text was updated successfully, but these errors were encountered:
My main complaint with the
polling
API is the fact that it doesn't exposesys::Events
; instead, it reads events from thesys::Events
into aVec<Event>
. In practice, this usually means that:Events
.poller
events are read out of theEvents
.poller
events are appended to aVec<Event>
.poller
events are then drained out of thatVec<Event>
and used to react to events.Steps 1 and 2 are necessary, but steps 3 and 4 feel unnecessary. It would be nice if the
Events
structure was exposed and given a real API. Is there any particular reason whypolling
was designed to useVec<Event>
in the first place?This would be a breaking change, but there's already breaking changes on the horizon (#38) so we should probably at least plan for this.
The text was updated successfully, but these errors were encountered: