Extract the Events struct and make the Event struct opaque #133
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: John Nunley <[email protected]>
This prevents the need to have an intermediate buffer to read events from, reducing the need for an allocation and a copy. This is a breaking change. Signed-off-by: John Nunley <[email protected]>
Foundation for more details later on. Signed-off-by: John Nunley <[email protected]>
Signed-off-by: John Nunley <[email protected]>
notgull
force-pushed
the
notgull/opaque-events
branch
from
8983311
to
c962381
Compare
fogti
reviewed
Aug 11, 2023
fogti
reviewed
Aug 11, 2023
fogti
reviewed
Aug 11, 2023
|
Imo it would be a good idea to squash all the doctest fixups before merging. |
- Make sure that waitable handles interact properly with the new infrastructure - Fix failing doctests Signed-off-by: John Nunley <[email protected]>
- Make set_* take a boolean for the value of the flag - Make Events !Sync - Fix visibility modifiers - Inline more methods - Use a better strategy for testing Signed-off-by: John Nunley <[email protected]>
notgull
force-pushed
the
notgull/opaque-events
branch
from
8708878
to
1a10d2a
Compare
fogti
reviewed
Aug 13, 2023
fogti
reviewed
Aug 13, 2023
This removes one of the mutexes that we have to lock. Signed-off-by: John Nunley <[email protected]>
Signed-off-by: John Nunley <[email protected]>
This was referenced Aug 15, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Eventsstruct fromPoller. This allows us to avoid an intermediate allocation when polling for events inasync-io.Eventopaque, containing platform-specific data. Closes Expose the Events structure instead of using Vec<Event> #66.HUPandPRItracking toEventthat is platform-dependent. Closes Enable HUP tracking in Event #112 and this issue.