Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove libc from dev deps #146

Merged
merged 3 commits into from
Sep 4, 2023
Merged

Remove libc from dev deps #146

merged 3 commits into from
Sep 4, 2023

Conversation

notgull
Copy link
Member

@notgull notgull commented Sep 4, 2023

@notgull
Remove libc from dev deps
dabbde1 
Signed-off-by: John Nunley <[email protected]>
@notgull notgull mentioned this pull request Sep 4, 2023
Merged
@fogti
Copy link
Member

fogti commented Sep 4, 2023 •
edited
Loading

I'd prefer just re-exporting rustix::process::Signal itself...

(the doctests would also need to be fixed...)

https://github.com/smol-rs/polling/tree/fogti/no-libc

@notgull
Copy link
Member Author

notgull commented Sep 4, 2023

rustix is an unstable crate with pretty frequent breaking changes. We can't export anything from that crate.

@notgull
Fix failing doctests
a89297b 
Signed-off-by: John Nunley <[email protected]>
fogti
fogti reviewed Sep 4, 2023
View reviewed changes
Cargo.toml Outdated Show resolved Hide resolved
@notgull
Stray empty line
24ac343 
Signed-off-by: John Nunley <[email protected]>
@fogti fogti merged commit 7718565 into master Sep 4, 2023
22 of 24 checks passed
@fogti fogti deleted the notgull/devdeps branch September 4, 2023 20:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fogti fogti fogti approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@notgull @fogti