Manage sources being inserted into kqueue #153
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Thus far, our kqueue implementation has been a relatively thin layer on top of the OS kqueue. However, kqueue doesn't keep track of when the same source is inserted twice, or when a source that doesn't exist is removed. In the interest of keeping consistent behavior between backends this commit adds a system for tracking when sources are inserted. Closes #151 Signed-off-by: John Nunley <[email protected]>
Signed-off-by: John Nunley <[email protected]>
Signed-off-by: John Nunley <[email protected]>
Signed-off-by: John Nunley <[email protected]>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thus far, our kqueue implementation has been a relatively thin layer on top of the OS kqueue. However, kqueue doesn't keep track of when the same source is inserted twice, or when a source that doesn't exist is removed. In the interest of keeping consistent behavior between backends this commit adds a system for tracking when sources are inserted.
Closes #151