Fix: replace is_connect_failed with is_err

[irvingoujAtDevolution]

In linux, epoll, EPOLLHUP may happen even if no connection call is made. It would confuse callers for what is actually happening.
Replaced is_connect_failed, and we detect if connection failed by using the combination of is_err and is_interrupt, please see the example, tcp_client

[notgull]

Unfortunately we can't change is_connect_failed as that would be a breaking change. So we have to keep the name the same there.

[irvingoujAtDevolution]

Unfortunately we can't change is_connect_failed as that would be a breaking change. So we have to keep the name the same there.

I apologize for my previous mistake. I would like to have your opinion on whether it is better to add is_err, mark is_connect_fail as deprecated, or simply keep using the same name but change the implementation.

I would argue that the first approach is better, as it aligns with the semantics it provides.

[notgull]

I apologize for my previous mistake. I would like to have your opinion on whether it is better to add is_err, mark is_connect_fail as deprecated, or simply keep using the same name but change the implementation.

I would argue that the first approach is better, as it aligns with the semantics it provides.

I'd argue that the first would be better.

[notgull]

I would appreciate not changing this example and instead just wrapping the socket error bits in the configuration guards.

[irvingoujAtDevolution]

can you elaborate what you mean by that?

[notgull]

Don't modify the Example too much; just make it so the is_err-specific code is guarded.

[irvingoujAtDevolution]

please have a look again, I am not exactly sure if this is how you want it.

[notgull]

Overall LGTM, just some minor considerations regarding docs.

[notgull]

LGTM aside from one minor nitpick

[irvingoujAtDevolution]

😢 , @notgull could you please help me look at the wine CI thing? I have no idea how that works

[notgull]

Looks like a spurious error.

[notgull]

Thanks!