-
Notifications
You must be signed in to change notification settings - Fork 68
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: ported to Vita target #197
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we add a test for this in CI? Just a cargo check
would suffice.
Also, do you have a way of testing this on the actual Vita software?
Running tests requires an actual piece of hardware (no way to run in qemu, since Vita runs a proprietary OS that demands specific hardware). Cargo check though is absolutely doable, will add it. Currently, I run tests on a physical device using
At the same time, I run another plain text TCP socket server on my computer, and Vita runs a module that pipes stdin and stdout to that TCP socket, making it possible to see test results. |
Fixed the comment, added check to CI and enabled CI check for tier 3 nightly targets |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm assuming the tests pass when you run it on actual hardware, right?
Yes, I run them on the actual hardware, and all of them pass (except for the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! NetBSD failure looks spurious
steps: | ||
- uses: actions/checkout@v4 | ||
- name: Install Rust | ||
run: rustup update stable | ||
run: rustup update ${{ matrix.rust }} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Instead of adding +nightly
to all cargo command calls, I recommended using && rustup default ${{ matrix.rust }}
here.
Previously in the "cross" CI job, checks would use "+nightly" to ensure that the nightly compiler is used. However this adds a lot of noise. In order to clean up CI this commit replaces "+nightly" with "rustup default nightly" at the start of the job. cc #197 (comment) Signed-off-by: John Nunley <[email protected]>
Previously in the "cross" CI job, checks would use "+nightly" to ensure that the nightly compiler is used. However this adds a lot of noise. In order to clean up CI this commit replaces "+nightly" with "rustup default nightly" at the start of the job. cc #197 (comment) Signed-off-by: John Nunley <[email protected]>
Fixes #160
Notes
signal-hook
does not compile and won't work on Vita,pthread_kill
is a stub in Vitanewlib
NONBLOCK
flag from the read side of the pipe whenwait
detectsnotified
before polling