Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add type and breakpoint props to Grid #444

Closed
wants to merge 0 commits into from
Closed

Add type and breakpoint props to Grid #444

wants to merge 0 commits into from

Conversation

namakshenas
Copy link
Contributor

Fixes #428 / Add type and breakpoint props to Grid

@AnnMarieW
Copy link
Collaborator

@namakshenas
Thanks for the update! Can you please include the sample apps you used to try out these new features? It's fine to just included them in the comments here so they can be copy & pasted and run locally on this branch.

@AnnMarieW
Copy link
Collaborator

Hi @namakshenas

Just checking in -- it would be great to get this in the next release. Can you let me know if you still have the time to work on this?

  • Need to include sample apps (or tests) for the new props.
  • Reconcile this PR with Add type prop to SimpleGrid #433. It look like the changes from 433 are included here. It's OK to just keep it like this, or to make them two separate PRs.
  • Fix conflict
  • looks like the breakpoints type is not correct. It should be GridBreakpoints

@namakshenas namakshenas closed this Jan 8, 2025
@namakshenas namakshenas force-pushed the add-type-breakpoint-grid branch from dc22a60 to 83a1cc1 Compare January 8, 2025 16:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add missing props
2 participants
@namakshenas @AnnMarieW