Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SNOW-1825790 Separate secure storage managers based on file and keyring #1295

Merged
merged 2 commits into from
Jan 31, 2025

Conversation

sfc-gh-pfus
Copy link
Collaborator

@sfc-gh-pfus sfc-gh-pfus commented Jan 30, 2025

Description

SNOW-1825790 Separate secure storage managers to make them easier to extend.

Checklist

  • Created tests which fail without the change (if possible)
  • Extended the README / documentation, if necessary

@sfc-gh-pfus sfc-gh-pfus force-pushed the SNOW-1825790-secure-storage-refactor branch 2 times, most recently from 53f53d4 to 205f50d Compare January 30, 2025 07:42
@sfc-gh-pfus sfc-gh-pfus marked this pull request as ready for review January 30, 2025 08:49
@sfc-gh-pfus sfc-gh-pfus requested a review from a team as a code owner January 30, 2025 08:49
Copy link

codecov bot commented Jan 30, 2025

Codecov Report

Attention: Patch coverage is 62.76596% with 70 lines in your changes missing coverage. Please review.

Project coverage is 82.16%. Comparing base (e5ae90f) to head (0265874).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
secure_storage_manager.go 61.53% 70 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1295      +/-   ##
==========================================
- Coverage   82.30%   82.16%   -0.14%     
==========================================
  Files          55       55              
  Lines       13600    13636      +36     
==========================================
+ Hits        11193    11204      +11     
- Misses       2407     2432      +25     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sfc-gh-pfus sfc-gh-pfus force-pushed the SNOW-1825790-secure-storage-refactor branch from 205f50d to 49535d4 Compare January 30, 2025 09:24
secure_storage_manager.go Outdated Show resolved Hide resolved
@sfc-gh-pfus sfc-gh-pfus merged commit e926883 into master Jan 31, 2025
37 of 39 checks passed
@sfc-gh-pfus sfc-gh-pfus deleted the SNOW-1825790-secure-storage-refactor branch January 31, 2025 13:12
@github-actions github-actions bot locked and limited conversation to collaborators Jan 31, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants