Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SNOW-1882588 Add Test for PR 2136 #2138

Merged
merged 1 commit into from
Jan 17, 2025
Merged

SNOW-1882588 Add Test for PR 2136 #2138

merged 1 commit into from
Jan 17, 2025

Conversation

sfc-gh-bli
Copy link
Contributor

Please answer these questions before submitting your pull requests. Thanks!

  1. What GitHub issue is this PR addressing? Make sure that there is an accompanying issue to your PR.

SNOW-1882588 Add Test for PR #2136

  1. Fill out the following pre-review checklist:

    • I am adding a new automated test(s) to verify correctness of my new code
    • I am adding new logging messages
    • I am adding a new telemetry message
    • I am modifying authorization mechanisms
    • I am adding new credentials
    • I am modifying OCSP code
    • I am adding a new dependency

  2. Please describe how your code solves the related issue.

    Please write a short description of how your code change solves the related issue.

  3. (Optional) PR for stored-proc connector:

@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 17, 2025 •
edited
Loading

All contributors have signed the CLA ✍️ ✅
Posted by the CLA Assistant Lite bot.

@sfc-gh-bli sfc-gh-bli added the NO-CHANGELOG-UPDATES This pull request does not need to update CHANGELOG.md label Jan 17, 2025
@sfc-gh-bli
Copy link
Contributor Author

I have read the CLA Document and I hereby sign the CLA

sfc-gh-mkeller
sfc-gh-mkeller approved these changes Jan 17, 2025
View reviewed changes
Copy link
Collaborator

@sfc-gh-mkeller sfc-gh-mkeller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚢 🚢

@sfc-gh-bli sfc-gh-bli merged commit 66cc90b into main Jan 17, 2025
92 of 95 checks passed
@sfc-gh-bli sfc-gh-bli deleted the snow-1882588 branch January 17, 2025 18:10
@github-actions github-actions bot locked and limited conversation to collaborators Jan 17, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@sfc-gh-mkeller sfc-gh-mkeller sfc-gh-mkeller approved these changes

Assignees
No one assigned
Labels
NO-CHANGELOG-UPDATES This pull request does not need to update CHANGELOG.md
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sfc-gh-bli @sfc-gh-mkeller