SNOW-1886694 - Track whether snowpark is running in an interactive environment #2879
+15
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ew/interactive-telemetry-track
sfc-gh-jkew
requested review from
sfc-gh-smirzaei,
sfc-gh-yixie and
sfc-gh-yuwang
|
Should be in draft for now. |
sfc-gh-mvashishtha
approved these changes
Jan 17, 2025
| @@ -51,6 +51,8 @@ | |||
| - Added an option `keep_column_order` for keeping original column order in `DataFrame.with_column` and `DataFrame.with_columns`. | |||
| - Added support for `contains_null` parameter to ArrayType. | |||
| - Added support for `value_contains_null` parameter to MapType. | |||
| - Added `interactive` to telemetry that indicates whether the current environment is an interactive one. | |||
|
|
|||
There was a problem hiding this comment.
Maybe delete this empty line to stay consistent.
sfc-gh-helmeleegy
approved these changes
Jan 17, 2025
sfc-gh-jjiao
approved these changes
Jan 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SNOW-1886694 - Track whether snowpark is running in an interactive environment
In order to improve interactive performance we need to track it, particularly for snowpandas. We use sys "ps1" and sys.flags.interactive for most runtime environments, but for snowbook we also look for a module availability. Snowbook notebooks can also run non-interactively; but snowbook does not set sys.flags.interactive right now. So this might over-count for snowbook until the flags are set properly.
pre-review checklist: