Http4s installation id telemetry #358
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stanch
reviewed
Oct 6, 2023
http4s/src/test/scala/com.snowplowanalytics.snowplow.collector.core/TelemetrySpec.scala
Outdated
Show resolved
Hide resolved
spenes
force-pushed
the
http4s-pipeline-id-telemetry
branch
from
9fbdb77 to
77d5b20
Compare
peel
approved these changes
Oct 6, 2023
kafka/src/main/scala/com.snowplowanalytics.snowplow.collectors.scalastream/TelemetryUtils.scala
Outdated
Show resolved
Hide resolved
...src/main/scala/com.snowplowanalytics.snowplow.collectors.scalastream/sinks/KinesisSink.scala
Show resolved
Hide resolved
spenes
force-pushed
the
http4s-pipeline-id-telemetry
branch
from
77d5b20 to
5d75c87
Compare
…r of micro for telemetry tests Telemetry needs new version of the schema from this PR (snowplow/iglu-central#1345), therefore PR branch is added as iglu repo to resolver. It is needed to make telemetry integration pass.
spenes
force-pushed
the
http4s-pipeline-id-telemetry
branch
from
5d75c87 to
af69088
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds ability to identify number of OS pipelines in the wild through telemetry. It finds out unique id that will outlive current instance, hashes it and attaches to telemetry event.
This new feature uses new version of
oss_contextschema. The PR for this schema is here. To make the tests pass, PR's branch is added as Iglu repo to telemetry integration tests.