Prevent Kafka sink from blocking #418
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, we used native Kafka sink implementation through kafka-clients. This caused an issue when actual `send` operation becomes blocking as the record write buffer fills and an actual send operation is performed. We're currently successfully using fs2-kafka in enrich with Enrich without major issues. Rewriting the Sink to use a two-effect pattern makes no sense and therefore fs2-kafka is used to prevent blocking problems.
peel
force-pushed
the
fix/kafka-sink-redo
branch
from
1fb2758 to
445d685
Compare
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, we used native Kafka sink implementation through kafka-clients. This caused an issue when actual
sendoperation becomes blocking as the record write buffer fills and an actual send operation is performed. We're currently successfully using fs2-kafka in enrich with Enrich without major issues. Rewriting the Sink to use a two-effect pattern makes no sense and therefore fs2-kafka is used to prevent blocking problems.