Disable timeouts on healthcheck calls #426
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
peel
force-pushed
the
bug/healthchecks-timeout
branch
2 times, most recently
from
88d119b to
6a68947
Compare
peel
force-pushed
the
bug/healthchecks-timeout
branch
3 times, most recently
from
c404837 to
689a96f
Compare
pondzix
approved these changes
Sep 4, 2024
Currently, healthchecks reside behind the same timeout settings as any other endpoint. We observed that when autoscaling under massive load, it is possible for collector to be taken down because of long health check responses. Which previously did not happen. We therefore move healthchecks above the timeout middleware to return to previous behavior. Additionally, this allows us to set arbitrarily short (or long) response times for the regular endpoints when necessary. --- Part of [PDP-1408].
The reference defaults should be less strict and match the settings we define upstream.
peel
force-pushed
the
bug/healthchecks-timeout
branch
from
2149ca5 to
088873a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, health checks reside behind the same timeout settings as any other endpoint. We observed that when autoscaling under massive load, it is possible for collector to be taken down because of long health check responses.
Which previously did not happen. We therefore move health checks above the timeout middleware to return to previous behavior. Additionally, this allows us to set arbitrarily short (or long) response times for the regular endpoints when necessary.
We also update default health checks to match what we typically set by default.
Part of PDP-1408