feat: add scaleway provider with scaleway_function_namespace resource support #1648
Conversation
|
|
| @@ -21,7 +21,7 @@ | |||
|
|
|||
| <p align="center"> | |||
| Measures infrastructure as code coverage, and tracks infrastructure drift.<br> | |||
| <strong>IaC:</strong> Terraform. <strong>Cloud providers:</strong> AWS, GitHub, Azure, GCP.<br> | |||
| <strong>IaC:</strong> Terraform. <strong>Cloud providers:</strong> AWS, GitHub, Azure, GCP, Scaleway (alpha).<br> | |||
There was a problem hiding this comment.
I've added Scaleway in the list of providers here (but advertised it's still in alpha since only one resource is available). Tell me if we should wait before putting it in the README!
| ) | ||
|
|
||
| func InitResourcesMetadata(resourceSchemaRepository resource.SchemaRepositoryInterface) { | ||
| initScalewayFunctionNamespace(resourceSchemaRepository) |
There was a problem hiding this comment.
For other providers, is there a way to automatically generate that code? I feel like we could π€
Codecov Report
π£ This organization is not using Codecovβs GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more Additional details and impacted files@@ Coverage Diff @@
## main #1648 +/- ##
==========================================
- Coverage 79.60% 78.02% -1.59%
==========================================
Files 229 224 -5
Lines 7183 7030 -153
==========================================
- Hits 5718 5485 -233
- Misses 1270 1347 +77
- Partials 195 198 +3
|
| scw.WithDefaultRegion(scw.RegionFrPar), | ||
| scw.WithDefaultZone(scw.ZoneFrPar1), | ||
| scw.WithUserAgent(fmt.Sprintf("driftctl/%s", version.Current())), | ||
| scw.WithProfile(profile), |
There was a problem hiding this comment.
If the profile contains a region (e.g. fr-par, nl-ams, pl-waw), the client will use this region instead of the default fr-par. Also, since one client can only process resources on one region, when listing resources (e.g. function namespaces), we'll only get resources from that specific region. I took a look at other providers like AWS, and it looks like it's the same behavior. Could you confirm? π
|
Hello @wbeuil π have you had the chance to take a look at this? Any feedback would be appreciated, thanks in advance! Also sorry for the ping, but I don't really know who else to tag π |
Description
Hello π
First of all, thanks for this great tool! π
This PR adds support for Scaleway provider. Scaleway is an european cloud provider.
I've followed the documentation to add a new provider, and also added a new resource (for testing purpose):
scaleway_function_namespace(a resource related to the serverless function product to logically group serverless functions). For reference, the description ofscaleway_function_namespaceis here, and the Terraform definition is here. I have added unit and acceptance tests to verify everything works properly.If this PR is satisfying, I'll try to add more resources. It should be probably possible to add more resources automatically from the Go SDK or the Terraform provider.
I also have a few questions since it's my first PR here (I've added GitHub comments on the related code).
Thank you very much π