Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix aws_iam_policy_attachment drift not detected, without removing aw… #1649

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

n2N8Z
Copy link
Contributor

@n2N8Z n2N8Z commented Mar 31, 2023

…s service role attachment ignore

Q A
🐛 Bug fix? yes
🚀 New feature? no
⚠ Deprecations? no
❌ BC Break no
🔗 Related issues 498, PR 498.
❓ Documentation no

Description

Restore ignoring of role attachments to aws service roles, which had been unnecessarily removed to fix #489, when the code that was removed actually had a logical error causing #489. So this restoration of the original code fixes #489, by not ignoring attachments to users or groups.

@n2N8Z n2N8Z requested a review from a team as a code owner March 31, 2023 18:53
@n2N8Z n2N8Z requested review from eliecharra and removed request for a team March 31, 2023 18:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

aws_iam_policy_attachment drift is not detected (0.7.1 regression)
1 participant