Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Vmware/VRO] Host API related changes for VRO #302

Merged
merged 5 commits into from
Dec 5, 2019

Conversation

NajmudheenCT
Copy link
Member

What this PR does / why we need it:
New HOST API has been added in hotpot, which has impact with volume attachement API. The VRO Attachment service need changes according to the new API
Which issue this PR fixes
: fixes #292

Test Report:

  1. Tested Create and Attach volume workflow from VRO Client , rescanned adapters and confiremd the attached disk is show in VMware ESX.
  2. Tested CreateDatastore workflow , which uses Attachment API. Workflow completed succesfully and verified that it is avaible in vmware datastores.

Copy link
Collaborator

@wisererik wisererik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Collaborator

@kumarashit kumarashit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kumarashit kumarashit merged commit d8c3e4b into sodafoundation:development Dec 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants