[SSP]Bucket access by users of tenants #1304
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1304 +/- ##
=======================================
Coverage 48.12% 48.12%
=======================================
Files 10 10
Lines 1571 1571
=======================================
Hits 756 756
Misses 756 756
Partials 59 59 |
rajat-soda
reviewed
Aug 18, 2021
api/pkg/backend/service.go
Outdated
| for _, tier := range tiersList.Tiers { | ||
| res := utils.ResourcesAlreadyExists(tier.Backends, id_array) | ||
| if len(res) != 0 { | ||
| errMsg := fmt.Sprintf("failed to delete backend because it is associated with some SSP") |
There was a problem hiding this comment.
associated with some SSP => associated with another SSP.
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind bug fix
What this PR does / why we need it:
This PR solves the problem that when an user is getting switched from a tenant to other tenant which it is a part of ,the S3 API is using inappropriate tenantID(ProjectID).Because of this ,bucket operations like create bucket ,list buckets are using inappropriate tenantID and access of buckets is handled in a wrong way(example: as in issue disscused in issue [SSP]When an User is assigned to two tenants, buckets created in one tenant are accessible in other tenant by same user #1303 )
Also validation is taken care when a backend is requested to delete it checks whether the backend is associated with any SSP and warning is given
Validation that when an update tier is requested need to check whether the delete backends has any buckets in them
Which issue(s) this PR fixes:
Fixes #1303
Fixes #1297 (partially)
Test Report Added?:
/kind TESTED
Test Report:
tenant1 users:
tenant2 users:
User3 as tenant1 is listing buckets created in tenant1 only:
User3 as tenant2 is listing buckets created in tenant2 only but not tenant1 buckets:
When trying to delete backend which is associated with an SSP(tier)
**When trying to delete a backend(with buckets) from tier backends **
Special notes for your reviewer:
In a scenario where an user is a part of multiple tenants, AK/SK is common but the authtoken varies
So we need to extract userId and tenantID using authtoken
In the existing S3API, x-auth-token value in the request is not validated.
And tenantID and userID are extracted and set as context using AK/SK in the signature filter
so we need to add auth filter where the validation of authtoken is done and tenantID and userId are extracted and set in the context using authtoken.