Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SSP]Admin to list all buckets #1306

Merged
merged 1 commit into from
Aug 30, 2021

Conversation

vineela1999
Copy link
Contributor

What type of PR is this?

Uncomment only one /kind <> line, hit enter to put that in a new line, and remove leading whitespace from that line:

/kind new feature

kind bug fix

/kind cleanup
/kind revert change
/kind design
/kind documentation
/kind enhancement

What this PR does / why we need it:
This PR solves a bug where admin can now be able to list down all the buckets(Admin+ user)
Which issue(s) this PR fixes:

Fixes #1297

Test Report Added?:

Uncomment only one /kind <> line, hit enter to put that in a new line, and remove leading whitespace from that line:

kind TESTED

/kind NOT-TESTED

Test Report:

User-u3 bucket list:
Screenshot from 2021-08-26 21-46-24

Admin buckets and u3 buckets are listed down:
Screenshot from 2021-08-26 21-46-09

Special notes for your reviewer:

@codecov
Copy link

codecov bot commented Aug 26, 2021

Codecov Report

Merging #1306 (863b1bc) into master (16c97b4) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #1306   +/-   ##
=======================================
  Coverage   48.12%   48.12%           
=======================================
  Files          10       10           
  Lines        1571     1571           
=======================================
  Hits          756      756           
  Misses        756      756           
  Partials       59       59           

Copy link
Collaborator

@kumarashit kumarashit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@PravinRanjan10
Copy link
Collaborator

LGTM

Copy link
Contributor

@rajat-soda rajat-soda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vineela1999 vineela1999 changed the title Admin to list all buckets [SSP]Admin to list all buckets Aug 28, 2021
Copy link
Member

@NajmudheenCT NajmudheenCT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@NajmudheenCT NajmudheenCT merged commit bb06780 into sodafoundation:master Aug 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[SSP] Sanity of SSP Feature
5 participants