-
-
Notifications
You must be signed in to change notification settings - Fork 81
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CI Pipeline Compatibility #124
base: master
Are you sure you want to change the base?
Conversation
- Add "strictMode" functionality - "strictMode" is on by default - When enabled, an error is thrown when no Rust builds are found - When disabled, the error is suppressed - "strictMode" can be disabled with custom.rust.strictMode: false - Fix validation warning - serverless does not accept "rust" as a runtime - a function can be marked as "rust" the old way, or by adding tags.language: "rust" - Support predefined artifacts and skip recompile - This allows an artifact to be built in one CI-step and deployed in another - When artifact is defined, the artifact zip is uploaded and compile is skipped
Thanks for these changes! I think at this point in this project lifecycle, you might be be better off starting your own fork of this project since this version of it has been abandoned. I have been looking at gathering the changes from the different PR's available, and pre-existing forks, and merging them into one that we can continue development on. |
- Update tests to correct some pre-existing failures and test around strictMode
I noticed when I forked that some tests weren't passing. Added a commit with lint passing (my mistake), updates to the test for my code, and fixes to the pre-existing failures. |
We did fork internally and it's working like a charm, but I figured it only made sense to at least offer it back. Low expectations on getting it merged in, but at the very least the diff is there for others who want similar behaviour. |
@TravisCalder you have just implemented what I was planning to do! |
I didn't see this reply, sorry about that. We're keeping an internal build
of it since we use GitLab but you're welcome to use the code from this Pull
Request. We're using it now for 4 different Serverless deployments with 1-3
lambdas per deployment and it's working like a charm.
…On Wed, Nov 15, 2023 at 5:02 AM nrodriguez-chub ***@***.***> wrote:
@TravisCalder <https://github.com/TravisCalder> you have just implemented
what I was planning to do!
This part to skip the build, is critical for us :D :D :
https://github.com/TravisCalder/serverless-rust/blob/master/index.js#L303
Did you publish a public release of this or are you planning to do so?
Thanks!
—
Reply to this email directly, view it on GitHub
<#124 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAG6A4ZWJOF36KUT4IRA7N3YESOM5AVCNFSM6AAAAAA5L26A2SVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQMJSGI4TAMZUG4>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
What did you implement:
Closes: #123
How did you verify your change:
Change was verified locally using
npm link
locally. The following scenarios were verified:custom.rust.strictMode
set tofalse
, provider changed toprovided.al2
provider.runtime
toprovided.al2
and addedtags: language: "rust"
param:artifact
as per linked issueserverless deploy --stage stage
, compile occurred as per usualserverless deploy --stage stage --param="artifact=path/file.zip"
build was skipped and provided artifact was deployed