Skip to content

Commit

Permalink
Change eslint ban-types to warning. (#2714)
Browse files Browse the repository at this point in the history
## Description

While looking at #2711 we decided to change `P extends Record<string, unknown>` to `P extends object` (issue author already created #2712). However, current CI won't allow this change because of `ban-types` eslint rule. I've decided to follow @tjzel suggestion and change this rule to warning instead of error.

## Test plan

Run `yarn lint:js-root`.
  • Loading branch information
m-bert authored Jan 4, 2024
1 parent 35ec17d commit 94c462b
Showing 1 changed file with 6 additions and 1 deletion.
7 changes: 6 additions & 1 deletion .eslintrc.json
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,11 @@
},
"parser": "@typescript-eslint/parser",
"parserOptions": {
"project": ["./tsconfig.json", "./example/tsconfig.json", "./FabricExample/tsconfig.json"]
"project": [
"./tsconfig.json",
"./example/tsconfig.json",
"./FabricExample/tsconfig.json"
]
},
"env": { "browser": true, "node": true, "jest/globals": true },
"plugins": ["jest"],
Expand All @@ -32,6 +36,7 @@
"@typescript-eslint/no-unsafe-call": "warn",
"@typescript-eslint/no-unsafe-assignment": "warn",
"@typescript-eslint/no-unsafe-return": "warn",
"@typescript-eslint/ban-types": "warn",

// common
"@typescript-eslint/explicit-module-boundary-types": "off",
Expand Down

0 comments on commit 94c462b

Please sign in to comment.