Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump prettier to version 3.3.3 #3198

Merged
merged 7 commits into from
Nov 27, 2024
Merged

Conversation

latekvo
Copy link
Contributor

@latekvo latekvo commented Nov 6, 2024

Description

Bump prettier version to 3.3.3.
Required for this issue to be resolved.

Test plan

  • confirm all CIs are passing
  • confirm none of the examples are crashing

@latekvo latekvo marked this pull request as ready for review November 13, 2024 14:50
@latekvo latekvo requested a review from m-bert November 13, 2024 14:50
Copy link
Contributor

@m-bert m-bert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't like those commas that I've mentioned earlier, but we can remove them for example in GH3 😅

@latekvo
Copy link
Contributor Author

latekvo commented Nov 27, 2024

we can remove them [...] in GH3

Sure

@latekvo latekvo merged commit e827e9b into main Nov 27, 2024
4 checks passed
@latekvo latekvo deleted the @latekvo/bump-prettier-to-3-3-3 branch November 27, 2024 13:17
latekvo added a commit that referenced this pull request Nov 27, 2024
## Description

<!--
Description and motivation for this PR.

Include 'Fixes #<number>' if this is fixing some issue.
-->


I merged 2 separate `package.json` updates at once.
([prettier](#3198)
&
[fabric](#3204))
Both had individually correct `yarn.lock` files, but upon merging one of
them, the other one had a simple conflict which i resolved without
updating the `yarn.lock` file.

This PR resolves this oversight.

## Test plan

<!--
Describe how did you test this change here.
-->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants