Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose per-crate cfg sets in scarb metadata #1076

Closed
mkaput opened this issue Jan 22, 2024 · 0 comments · Fixed by #1085 or #1084
Closed

Expose per-crate cfg sets in scarb metadata #1076

mkaput opened this issue Jan 22, 2024 · 0 comments · Fixed by #1085 or #1084
Assignees

Comments

@mkaput
Copy link
Member

mkaput commented Jan 22, 2024

Problem

Cairo 2.5.0 introduced per-crate cfg sets (starkware-libs/cairo#4831). We need to include them in scarb-metadata output.

Proposed Solution

Add a new field to CompilationUnitComponentMetadata:

#[serde(default)]
pub cfg: Vec<Cfg>

and populate it with cfg items to-be-attached to this unit.

The global per-unit cfg items set should get main component's cfg items, for backwards compatibility reason.

Notes

  1. Don't forget about extensions that are pulling information from.
  2. Make scarb-metadata release after merging these changes.
@github-project-automation github-project-automation bot moved this to Triage in Scarb Jan 22, 2024
@mkaput mkaput moved this from Triage to Todo in Scarb Jan 22, 2024
@szymmis szymmis moved this from Todo to In Progress in Scarb Jan 25, 2024
@szymmis szymmis linked a pull request Jan 25, 2024 that will close this issue
@szymmis szymmis linked a pull request Feb 1, 2024 that will close this issue
@github-project-automation github-project-automation bot moved this from In Progress to Done in Scarb Feb 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
2 participants