Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do not compile tests from dependencies in scarb test #1084

Merged
merged 7 commits into from
Feb 7, 2024
Merged

Do not compile tests from dependencies in scarb test #1084

merged 7 commits into from
Feb 7, 2024

Conversation

szymmis
Copy link
Contributor

@szymmis szymmis commented Jan 25, 2024 •
edited
Loading

@szymmis szymmis mentioned this pull request Jan 25, 2024
Merged
@szymmis szymmis force-pushed the szymmis/deps-test-compilation branch from bd58c5e to 9298c13 Compare February 1, 2024 12:00
@szymmis szymmis linked an issue Feb 1, 2024 that may be closed by this pull request
Expose per-crate cfg sets in scarb metadata #1076
Closed
@szymmis
Copy link
Contributor Author

szymmis commented Feb 1, 2024

Decided to merge #1085 into this PR as they share the same logic and it doesn't make sens to keep them separate.

maciektr
maciektr reviewed Feb 1, 2024
View reviewed changes
Copy link
Contributor

@maciektr maciektr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😄

scarb/src/compiler/compilers/test.rs Outdated Show resolved Hide resolved
scarb/src/compiler/compilation_unit.rs Outdated Show resolved Hide resolved
scarb/src/ops/resolve.rs Outdated Show resolved Hide resolved
scarb/src/ops/resolve.rs Outdated Show resolved Hide resolved
scarb/src/ops/resolve.rs Outdated Show resolved Hide resolved
scarb/src/ops/resolve.rs Outdated Show resolved Hide resolved
@szymmis szymmis force-pushed the szymmis/deps-test-compilation branch from 2687248 to 6397ed4 Compare February 5, 2024 13:14
@szymmis szymmis linked an issue Feb 5, 2024 that may be closed by this pull request
Do not compile tests in dependency packages in scarb test #940
Closed
maciektr
maciektr reviewed Feb 5, 2024
View reviewed changes
Copy link
Contributor

@maciektr maciektr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔥 Please find some minor comments attached.

scarb-metadata/src/lib.rs Outdated Show resolved Hide resolved
scarb/src/ops/resolve.rs Outdated Show resolved Hide resolved
scarb/src/ops/resolve.rs Outdated Show resolved Hide resolved
scarb/src/ops/resolve.rs Show resolved Hide resolved
scarb/src/ops/resolve.rs Outdated Show resolved Hide resolved
@szymmis szymmis force-pushed the szymmis/deps-test-compilation branch from 6397ed4 to 2e490c4 Compare February 6, 2024 08:32
maciektr
maciektr approved these changes Feb 6, 2024
View reviewed changes
scarb-metadata/src/lib.rs Outdated Show resolved Hide resolved
@szymmis szymmis force-pushed the szymmis/deps-test-compilation branch from 33c9dca to 2e490c4 Compare February 7, 2024 09:11
@szymmis szymmis force-pushed the szymmis/deps-test-compilation branch from 2e490c4 to d5cd2e4 Compare February 7, 2024 09:12
@szymmis szymmis enabled auto-merge February 7, 2024 09:12
@szymmis szymmis added this pull request to the merge queue Feb 7, 2024
Merged via the queue into main with commit 7e127a9 Feb 7, 2024
21 checks passed
@szymmis szymmis deleted the szymmis/deps-test-compilation branch February 7, 2024 09:49
@chenrui333 chenrui333 mentioned this pull request Feb 15, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mkaput mkaput mkaput left review comments

@maciektr maciektr maciektr approved these changes

@tomek0123456789 tomek0123456789 Awaiting requested review from tomek0123456789

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Expose per-crate cfg sets in scarb metadata Do not compile tests in dependency packages in scarb test
3 participants
@szymmis @mkaput @maciektr