Revert "Rename experimental_features -> allow_features (#1058)"

extensions/scarb-snforge-test-collector/src/metadata.rs

@@ -125,7 +125,7 @@ impl CompilationUnit<'_> {
                         // TODO (#1040): replace this with a macro
                         experimental_features: ExperimentalFeaturesConfig {
                             negative_impls: pkg
-                                .allow_features
+                                .experimental_features
                                 .contains(&String::from("negative_impls")),
                         },
                     },

scarb-metadata/src/lib.rs

@@ -232,7 +232,7 @@ pub struct PackageMetadata {
     pub manifest_metadata: ManifestMetadata,
 
     /// Compiler experimental features allowed for this package.
-    pub allow_features: Vec<String>,
+    pub experimental_features: Vec<String>,
 
     /// Additional data not captured by deserializer.
     #[cfg_attr(feature = "builder", builder(default))]

scarb/src/compiler/db.rs

@@ -93,14 +93,14 @@ fn build_project_config(unit: &CompilationUnit) -> Result<ProjectConfig> {
         .components
         .iter()
         .map(|component| {
-            let allow_features = component.package.manifest.allow_features.clone();
+            let experimental_features = component.package.manifest.experimental_features.clone();
             (
                 component.cairo_package_name(),
                 CrateSettings {
                     edition: component.package.manifest.edition,
                     // TODO (#1040): replace this with a macro
                     experimental_features: cairo_lang_filesystem::db::ExperimentalFeaturesConfig {
-                        negative_impls: allow_features
+                        negative_impls: experimental_features
                             .unwrap_or_default()
                             .contains(&SmolStr::new_inline("negative_impls")),
                     },

scarb/src/core/manifest/mod.rs

@@ -51,7 +51,7 @@ pub struct Manifest {
     pub scripts: BTreeMap<SmolStr, ScriptDefinition>,
     /// Allow experimental features.
     #[builder(default)]
-    pub allow_features: Option<Vec<SmolStr>>,
+    pub experimental_features: Option<Vec<SmolStr>>,
 }
 
 /// Subset of a [`Manifest`] that contains package metadata.

scarb/src/core/manifest/toml_manifest.rs

@@ -198,7 +198,7 @@ pub struct TomlPackage {
     /// **UNSTABLE** This package does not depend on Cairo's `core`.
     pub no_core: Option<bool>,
     pub cairo_version: Option<MaybeWorkspaceField<VersionReq>>,
-    pub allow_features: Option<Vec<SmolStr>>,
+    pub experimental_features: Option<Vec<SmolStr>>,
 }
 
 #[derive(Clone, Debug, Serialize, Eq, PartialEq)]
@@ -558,15 +558,15 @@ impl TomlManifest {
             .unwrap_or_default();
 
         // TODO (#1040): add checking for fields that are not present in ExperimentalFeaturesConfig
-        let allow_features = package.allow_features.clone();
+        let experimental_features = package.experimental_features.clone();
         let manifest = ManifestBuilder::default()
             .summary(summary)
             .targets(targets)
             .edition(edition)
             .metadata(metadata)
             .compiler_config(compiler_config)
             .scripts(scripts)
-            .allow_features(allow_features)
+            .experimental_features(experimental_features)
             .build()?;
         Ok(manifest)
     }

scarb/src/core/publishing/manifest_normalization.rs

@@ -75,7 +75,7 @@ fn generate_package(pkg: &Package) -> Box<TomlPackage> {
         repository: metadata.repository.clone().map(MaybeWorkspace::Defined),
         no_core: summary.no_core.then_some(true),
         cairo_version: metadata.cairo_version.clone().map(MaybeWorkspace::Defined),
-        allow_features: pkg.manifest.allow_features.clone(),
+        experimental_features: pkg.manifest.experimental_features.clone(),
     })
 }
 

scarb/src/ops/metadata.rs

@@ -135,9 +135,9 @@ fn collect_package_metadata(package: &Package) -> m::PackageMetadata {
 
     let edition = edition_variant(package.manifest.edition);
 
-    let allow_features: Vec<String> = package
+    let experimental_features: Vec<String> = package
         .manifest
-        .allow_features
+        .experimental_features
         .clone()
         .unwrap_or_default()
         .iter()
@@ -155,7 +155,7 @@ fn collect_package_metadata(package: &Package) -> m::PackageMetadata {
         .dependencies(dependencies)
         .targets(targets)
         .manifest_metadata(manifest_metadata)
-        .allow_features(allow_features)
+        .experimental_features(experimental_features)
         .build()
         .unwrap()
 }

scarb/tests/metadata.rs

@@ -1283,12 +1283,12 @@ fn includes_edition() {
 }
 
 #[test]
-fn includes_allowed_features() {
+fn includes_experimental_features() {
     let t = assert_fs::TempDir::new().unwrap();
     ProjectBuilder::start()
         .name("hello")
         .version("0.1.0")
-        .manifest_package_extra(r#"allow-features = ["negative_impls"]"#)
+        .manifest_package_extra(r#"experimental-features = ["negative_impls"]"#)
         .build(&t);
 
     let metadata = Scarb::quick_snapbox()
@@ -1303,6 +1303,6 @@ fn includes_allowed_features() {
         .get("hello")
         .unwrap()
         .clone()
-        .allow_features
+        .experimental_features
         .contains(&String::from("negative_impls")))
 }

website/docs/reference/manifest.md

@@ -209,13 +209,13 @@ Keys are human-readable link names, and values are URLs.
 "We're hiring" = "https://swmansion.com/careers/"
 ```
 
-### `allow-features`
+### `experimental-features`
 
-This field is responsible for setting unstable features to be used on the package for the compiler.
+This field is responsible for setting experimental flags to be used on the package for the compiler.
 
 ```toml
 [package]
-allow-features = ["negative_impls"]
+experimental-features = ["negative_impls"]
 ```
 
 ## `[dependencies]`