feat: allow custom names for proc macros #1781
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
At the moment, the macro name is the name of the function tagged with
`#[attribute_macro]/#[inline_macro]/#[derive_macro]`.
In Cairo, it is quite common to use the `::` separator in macro names,
but as this separator is not allowed in function names, we cannot use it
for Cairo proc macros.
This PR adds string litteral argument to allow to set a custom name for a
proc macros.
For example, here is a proc macro to process `dojo::model` attributes:
```rust
pub fn dojo_model(args: TokenStream, token_stream: TokenStream) -> ProcMacroResult {
}
```
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
At the moment, the macro name is the name of the function tagged with
#[attribute_macro]/#[inline_macro]/#[derive_macro].In Cairo, it is quite common to use the
::separator in macro names, but as this separator is not allowed in function names, we cannot use it for Cairo proc macros.This PR adds string litteral argument to allow to set a custom name for a proc macros.
For example, here is a proc macro to process
dojo::modelattributes: