Represent a package in Proc Macro Server more reliably #2042
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
integraledelebesgue
force-pushed
the
feature/pms-type-model-improvement
branch
2 times, most recently
from
070bf3d to
2955b2b
Compare
integraledelebesgue
changed the title
PackageId in Proc Macro ServerPackageId in Proc Macro Server
Draggu
reviewed
Mar 4, 2025
Draggu
reviewed
Mar 5, 2025
piotmag769
reviewed
Mar 5, 2025
integraledelebesgue
changed the title
PackageId in Proc Macro ServerPackageId in Proc Macro Server
integraledelebesgue
force-pushed
the
feature/pms-type-model-improvement
branch
2 times, most recently
from
3cc25ce to
2946b39
Compare
Draggu
approved these changes
Mar 6, 2025
integraledelebesgue
force-pushed
the
feature/pms-type-model-improvement
branch
from
2946b39 to
b72e7a8
Compare
piotmag769
requested changes
Mar 6, 2025
piotmag769
reviewed
Mar 6, 2025
integraledelebesgue
force-pushed
the
feature/pms-type-model-improvement
branch
2 times, most recently
from
6dbfd8c to
31ffcfa
Compare
integraledelebesgue
changed the title
PackageId in Proc Macro Server
integraledelebesgue
force-pushed
the
feature/pms-type-model-improvement
branch
from
31ffcfa to
d4305f6
Compare
piotmag769
approved these changes
Mar 6, 2025
integraledelebesgue
force-pushed
the
feature/pms-type-model-improvement
branch
3 times, most recently
from
9f96409 to
d5ad777
Compare
piotmag769
reviewed
Mar 6, 2025
integraledelebesgue
force-pushed
the
feature/pms-type-model-improvement
branch
2 times, most recently
from
5159327 to
eedb882
Compare
integraledelebesgue
force-pushed
the
feature/pms-type-model-improvement
branch
from
eedb882 to
63f8de6
Compare
integraledelebesgue
force-pushed
the
feature/pms-type-model-improvement
branch
from
63f8de6 to
21027ed
Compare
piotmag769
approved these changes
Mar 7, 2025
piotmag769
reviewed
Mar 7, 2025
| /// `PackageId.to_serialized_string()` which is always equal to | ||
| /// `scarb_metadata::CompilationUnitComponentId.repr`. | ||
| /// Each [`CompilationUnitComponentMacros`] in `macros_for_packages` should have | ||
| /// an exclusive `package` field which identifies it in the response. |
There was a problem hiding this comment.
Suggested change
| /// an exclusive `package` field which identifies it in the response. | |
| /// a unique `component` field which identifies it in the response. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Packagetype which wraps the name and discriminator of the Cairo package