-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Quick Notifications #192
Open
CxRes
wants to merge
7
commits into
solid:main
Choose a base branch
from
CxRes:quick-notifications
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Quick Notifications #192
Changes from 1 commit
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
b58b0c9
Add Quick Notifications
CxRes c7fef4f
Apply suggestions from TallTed's review
CxRes cad95f4
TallTed's Review Fixes Backported
CxRes d0b1ef1
On header reference to solid must be lowercase
CxRes e1a7800
Typo Fixed
CxRes ff6a6f0
Fix Examples
CxRes ed3b829
fix Unnecessary Repetition in Response Status
CxRes File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,7 @@ | ||
sequenceDiagram | ||
participant Subscription Client | ||
participant Resource Server | ||
|
||
Subscription Client ->> Resource Server: HEAD Resource (topic) | ||
Resource Server ->> Subscription Client: Existing Notifications Channels | ||
Resource Server ->> Subscription Client: Subscription Discovery |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,7 @@ | ||
sequenceDiagram | ||
participant Subscription Client | ||
participant Resource Server | ||
|
||
Resource Server -->> Subscription Client: Discovery Response | ||
Subscription Client ->> Resource Server: Subscription Request | ||
Resource Server ->> Subscription Client: Subscription Response (with Notification Channel) |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
404 I would suggest to add that link once it gets published
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My intention was that when the PR gets accepted, it will be created.
Happy to comment it out if it is a problem...