Hotfix/change cmake version #161
Conversation
|
@chestercheng and @terrychan999 could you please help take a look? |
|
@xingularity why 3.27.9 when 3.28.1 is available: https://www.kitware.com/cmake-3-28-1-available-for-download/ ? |
|
We can use the latest version if there are no breaking changes. |
|
I’m not sure why it needs to specify that version, but the changes LGTM |
|
Using specific version is generally more stable than using master/develop head |
scripts/build.d/cmake
Outdated
| @@ -8,12 +8,12 @@ pkgname=cmake | |||
|
|
|||
| if [ "${SRCSYNC}" == "tarball" ] ; then | |||
|
|
|||
| pkgver=${VERSION:-3.25.1} | |||
| pkgver=${VERSION:-3.27.9} | |||
There was a problem hiding this comment.
Thanks for your comment. That specific version is based on the error message I saw when I tried to build modmesh. There is a new command and it is included after 3.27. 3.27.9 is the latest version in 3.27. I haven't tried 3.28. Let me test if I can build modmesh with 3.28.
|
@xingularity when you finish the change please leave a global comment to request for review. No need to use the system button for it is not clear enough. |
In my latest commit, I have changed CMake version and corresponding hash to 3.28.1. I am now testing to build the environment. I will request for review, once I build Ok. |
|
If the cmake version is working, we can merge the PR. Can you confirm? |
The build of cmake is successful on Ubuntu Linux 22.04 and Mac. |
Change Make version to 3.27.9