Fix use flavor cmd #162
Merged
Fix use flavor cmd #162
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
j8xixo12
commented
May 5, 2024
| @@ -5,5 +5,6 @@ final_ret=0 | |||
| ./test_init_var.sh ; if [ $? != 0 ] ; then final_ret=1 ; fi | |||
| ./test_bash_utils.sh ; if [ $? != 0 ] ; then final_ret=1 ; fi | |||
| ./test_devenv_impl.sh ; if [ $? != 0 ] ; then final_ret=1 ; fi | |||
| ./test_init.sh ; if [ $? != 0 ] ; then final_ret=1 ; fi | |||
There was a problem hiding this comment.
Add a unit test to ensure the behavior of use command is expected.
chestercheng
requested changes
May 5, 2024
tests/test_init.sh
Outdated
| test_use_cmd() { | ||
| devenv add foo | ||
| devenv use foo | ||
| assertNotNull ${DEVENVFLAVOR} |
There was a problem hiding this comment.
I think using assertNotContains to check the result would be better
There was a problem hiding this comment.
What should be the value of $DEVENVFLAVOR after devenv use foo? If it should be foo, perhaps this may use assertEqual or something like it?
There was a problem hiding this comment.
I have refine the test case in 9ca221e
yungyuc
requested changes
May 5, 2024
tests/test_init.sh
Outdated
| test_use_cmd() { | ||
| devenv add foo | ||
| devenv use foo | ||
| assertNotNull ${DEVENVFLAVOR} |
There was a problem hiding this comment.
What should be the value of $DEVENVFLAVOR after devenv use foo? If it should be foo, perhaps this may use assertEqual or something like it?
|
@yungyuc, @chestercheng this patch is ready for review. |
yungyuc
approved these changes
May 7, 2024
tests/test_init.sh
Outdated
| test_use_cmd() { | ||
| devenv add foo | ||
| devenv use foo | ||
| assertNotNull ${DEVENVFLAVOR} |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this PR I fix a
usecommand issue which is theusecommand will use an unavailable flavor.After:
Before: