feat: bzip2 build script default using tarball #95
Conversation
scripts/build.d/bzip2
Outdated
| pkgfull=$pkgname-$pkgbranch | ||
| if [ -z "${SYNCGIT}" ]; then | ||
| pkgname=bzip2 | ||
| pkgver=${VERSION:-master} |
There was a problem hiding this comment.
Please use a released version. (I assume there is one.)
There was a problem hiding this comment.
The latest release version is 1.0.8, but this version still using Makefile as build system also having problem with building dynamic file at MacOS, therefore I choose master as default version.
There was a problem hiding this comment.
What if we go with a static library?
There was a problem hiding this comment.
Sorry for the late reply, you meant solvcon using bzip2 with static library?
if yes maybe I can try it this weekends !
There was a problem hiding this comment.
This is not an urgent issue and not late at all. Yes, something like that, but it is in devenv, we build bzip2 static lib instead of dynamic lib. If the consumer of bzip2 accepts static lib this may be a workaround?
There was a problem hiding this comment.
Bzip2 also build static library at v.1.0.8 and solvcon can be build with bzip2 static library, but when I ran the test, test failed due to ModuleNotFoundError: No module named '_bz2', it seems python can not find bzip2 with static library ?
There was a problem hiding this comment.
In theory it is possible to build Python using static bzip2 but you would probably need to look into Python's make file to know how to configure it that way.
j8xixo12
force-pushed
the
bzip2_tarball
branch
from
ab1f081 to
affa05d
Compare
| unzip ${DEVENVDLROOT}/${pkgfn} | ||
| pushd "${pkgname}-${pkgfull}" > /dev/null | ||
| # Added -fPIC into bzip2 CLFAGS | ||
| sed -i "s/CFLAGS=-Wall*/CFLAGS=-fPIC -Wall/1" Makefile |
There was a problem hiding this comment.
Using sed to modify CFLAGS in bzip2’ Makefile, added -fPIC into gcc compile option, then bzip2 static library can be used by python.
| unzip ${DEVENVDLROOT}/${pkgfn} | ||
| pushd "${pkgname}-${pkgfull}" > /dev/null | ||
| # Added -fPIC into bzip2 CLFAGS | ||
| sed -i "s/CFLAGS=-Wall*/CFLAGS=-fPIC -Wall/1" Makefile |
For #92 (comment), changed the build script to use tarball by default, currently bzip2 latest release still using makefile and the issue of clang build fail still exist, so I choice the master as default tarball version, and I tried to download .tar.gz, .tar and .zip, the there are unable to untar except .zip, so I choice zip file to download.
Maybe we can waiting for the next release, the change the default version to latest release.