Port most code to set up menu items and actions from C++ to Python #442
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… to Python by using PySide6
yungyuc
commented
Dec 20, 2024
| @@ -47,43 +47,6 @@ class RAction | |||
| QObject * parent = nullptr); | |||
| }; /* end class RAction */ | |||
|
|
|||
| class RPythonAction | |||
There was a problem hiding this comment.
With action setup code ported to Python, this helper class RPythonAction is not longer needed.
| QString m_pyFuncName; | ||
| }; /* end class RPythonAction */ | ||
|
|
||
| class RAppAction |
There was a problem hiding this comment.
With action setup code ported to Python, this helper class RAppAction is not longer needed.
| @@ -118,92 +118,15 @@ void RManager::setUpMenu() | |||
| // "exited with code -1073740791". The reason is not yet clarified. | |||
|
|
|||
| m_fileMenu = m_mainWindow->menuBar()->addMenu(QString("File")); | |||
| { | |||
There was a problem hiding this comment.
Remove the C++ code setting up menu items.
| m_viewMenu = m_mainWindow->menuBar()->addMenu(QString("View")); | ||
| { | ||
| // Code for controlling camera is not exposed to Python yet |
There was a problem hiding this comment.
Camera control is still in C++. We should expose it to Python later.
| void quit() { m_core->quit(); } | ||
|
|
||
| public slots: | ||
| QMenu * fileMenu() { return m_fileMenu; } |
There was a problem hiding this comment.
Expose menu objects for access from Python.
| mw = _vimpl.RManager.instance.mainWindow | ||
| mw.clearApplications() | ||
| populate_applications() | ||
| def populate_menu(): |
There was a problem hiding this comment.
Populate the menu in Python.
|
Merge for further GUI changes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Except the menu for camera control, which needs code that is only available in C++, port the menu and action setup from C++ to Python.