Refactor to rename viewer to pilot #446
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Plan to rename the binary naew "viewer" to a more unique name "pilot". The first step is to rename the Python module `modmesh.view` to `modmesh.pilot`. `modmesh.pilot` is a sub-package and will allow better GUI code organization.
yungyuc
added
refactor
yungyuc
commented
Dec 26, 2024
There was a problem hiding this comment.
This file modmesh/pilot/_gui.py comes from modmesh/view.py.
There was a problem hiding this comment.
modmesh.pilot will be a drop-in replacement to modmesh.view.
|
Merged the PR. Start to implement for issue #400. |
|
@j8xixo12 Please help take a look when you have time. We can fix issues with followup PRs. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rename the Python module
modmesh.viewto packagemodmesh.pilot.modmesh.pilotwill host all code related to GUI and visualization.Also rename the GUI executable from
viewertopilot.