[stormond] Added new dynamic field 'last_sync_time' to STATE_DB #535
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… for disk was last synced to STATE_DB
assrinivasan
requested review from
Junchao-Mellanox,
dgsudharsan,
Staphylo,
saiarcot895,
prgeor,
vdahiya12,
mihirpat1 and
vvolam
prgeor
reviewed
Sep 12, 2024
prgeor
reviewed
Nov 7, 2024
|
/azpw run coverage.Azure.sonic-platform-daemons.build_test |
|
/AzurePipelines run coverage.Azure.sonic-platform-daemons.build_test |
|
No pipelines are associated with this pull request. |
|
@prgeor @saiarcot895 failure appears to be a false flag? Code Coverage for scripts/stormond is at 83% as of the latest commit:
Am I missing something? EDIT: I was indeed missing something. Increased code coverage in latest commit. |
prgeor
approved these changes
Nov 27, 2024
vvolam
pushed a commit
to vvolam/sonic-platform-daemons
that referenced
this pull request
Jan 3, 2025
…c-net#535) * Added new dynamic field 'last_sync_time' that shows when STORAGE_INFO for disk was last synced to STATE_DB * Moved 'start' message to actual starting point of the daemon * Added functions for formatted and epoch time for user friendly time display * Made changes per prgeor review comments * Pivot to SysLogger for all logging * Increased log level so that they are seen in syslogs * Code coverage improvement
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Currently the Storage monitoring Daemon does not provide any information on when it last synced attributes of each storage device onto the database. This PR adds new dynamic field called
last_sync_timethat shows when STORAGE_INFO fields for each disk was last synced to STATE_DB. The value is in Unix timestamp format.HLD Change PR: sonic-net/SONiC#1784
Motivation and Context
The motivation is that this field would provide additional context in case of repeated daemon crashes scenario ending up with the daemon status =
FATAL Exited too quickly (process log may have details).How Has This Been Tested?
Manually tested my changes on a DUT:
FATALscenario:Thus we can see that the storage attributes for the nvme0n1 disk have not been updated in (1724487680 - 1724486210.5309312) = 1469 seconds ~= 25 minutes.