Build - use built-in RtMidi by default on Linux #29
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm in favour of this. @llloret do you have any thoughts? |
|
Since sonic-pi-net/sonic-pi#3066 was merged, I'll give this PR a bump for review since it somewhat compliments that other one (by providing more agency in deciding whether to link against system libs or use vendored/vcpkg libs) |
|
Great call @lilyinstarlight - thanks for this :-) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This follows the discussion in sonic-pi-net/sonic-pi#2542 and updates CMakeLists to default to including RtMidi on Linux, unless it was specifically asked to be excluded using the
USE_SYSTEM_RTMIDICMake option (e.g.cmake -DUSE_SYSTEM_RTMIDI=ON)Names of the option or wording or whatever else can be changed if anyone feels it is unclear
Supersedes sonic-pi-net/sonic-pi#2542