Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add help command that displays docs for all commands in a category #1054

Closed
wants to merge 1 commit into from

Conversation

calebj
Copy link
Contributor

@calebj calebj commented Mar 30, 2016

@dgw edit: Requires changes made in #1053 to work.


cmds = bot._command_groups[name]
for cmd in cmds:
cmd_names = name.upper() + ' : ' + '|'.join(cmd)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This causes command names to have | between each character, not sure if that's intended.

<@maxpowa> .module help
<Sopel> HELP : m|o|d|u|l|e : no documentation available for this command.   
<Sopel> HELP : h|e|l|p : no documentation available for this command.   

@calebj
Copy link
Contributor Author

calebj commented Apr 4, 2016

The patch assumes that cmds is a list of strings that are aliases for a command, not just a string. That change is in my other PR.

@maxpowa
Copy link
Contributor

maxpowa commented Sep 30, 2016

Blocked by #1053

@calebj
Copy link
Contributor Author

calebj commented Nov 21, 2017

Rebased both this and #1053

@dgw dgw self-requested a review March 27, 2018 14:48
@dgw dgw added this to the 6.6.0 milestone May 16, 2018
@dgw dgw modified the milestones: 6.6.0, 7.0.0 Jul 10, 2018
@dgw
Copy link
Member

dgw commented Jul 10, 2018

Reassigning to Sopel 7, along with its sister PR, at least until @calebj responds.

@dgw
Copy link
Member

dgw commented Feb 15, 2019

Current development direction looks like someone will have to take this and possibly rework it on top of whatever changes happen after @Exirel and @HumorBaby finish reworking the (re)loading of plugins. We're definitely into "let's wait and see" territory, at this point.

@dgw dgw removed their request for review February 28, 2019 09:59
@dgw dgw added the Stale Mostly used for PRs that no longer work and need updating before re-review/merge. label Feb 28, 2019
@dgw dgw removed this from the 7.0.0 milestone Feb 28, 2019
@Exirel
Copy link
Contributor

Exirel commented May 8, 2019

@dgw edit: Requires changes made in #1053 to work.

Welp. I think the sensible thing to do here is to close this PR. So many things have changed since its first commit that I believe it's better to start fresh from master, and craft a new solution.

@Exirel Exirel closed this May 8, 2019
@dgw
Copy link
Member

dgw commented May 9, 2019

It's a good call, since @calebj hasn't been active in a while. I worry that we'll lose track of this without the open PR, though… but if it's on your own list, @Exirel, then I will not worry! 😁

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature Stale Mostly used for PRs that no longer work and need updating before re-review/merge.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants