Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

spellcheck: remove plugin (moving to separate package) #1675

Merged
merged 1 commit into from
Oct 30, 2019
Merged

Conversation

dgw
Copy link
Member

@dgw dgw commented Aug 6, 2019

Removed all relevant search hits for "spellcheck", "aspell", and/or "enchant".

Working on the new package locally; I plan to make it installable from PyPI as sopel-spellcheck when it's ready to publish. New repo will be sopel-irc/sopel-spellcheck.

See #1642. Note that this breaks the transition plan described in #1291, but adding sopel-spellcheck to the requirements for Sopel 7 would only perpetuate the dependency hell we're trying to solve.

Removed plugin file, requirements, Travis extras, and all relevant
search hits for "spellcheck", "aspell", and/or "enchant".
Copy link
Contributor

@Exirel Exirel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This feels so good.

@dgw dgw merged commit ca37846 into master Oct 30, 2019
@dgw dgw deleted the remove-spellcheck branch October 30, 2019 22:06
@dgw
Copy link
Member Author

dgw commented Oct 30, 2019

The plugin is now installable from https://pypi.org/project/sopel-spellcheck/ (or see the repo).

Note: As PyPI does not have any release of Sopel 7.x available yet, this requires an existing "editable" install of Sopel @ 40162a4 or newer. pip will not be able to satisfy the sopel>=7.0 dependency on its own until we begin publishing alpha/beta/RC versions.

@dgw dgw mentioned this pull request Jun 26, 2021
40 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants