ipython: remove plugin (moving to separate package) #1684
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
IPython as a dependency isn't as fiddly as aspell (see discussion in #1291, #1640, #1642), but it's still unnecessary install-bloat that applies only to a small portion of the user base.
ipython
andspellcheck
should be the only exceptions to the package-ization plan outlined in #1291, which targets most removals for Sopel 8 (our next next major release).Removed plugin file, requirements, test exclusions (???), and contrib script for hiding warnings generated by IPython. (I don't know if that contrib script even still does anything.)
New package will live at sopel-irc/sopel-ipython, and will be published on PyPI as
sopel-ipython
. @sopel-irc/rockstars, I'd like your opinions on whether the new package should be added as a requirement forsopel
, as dictated by the transition plan in #1291. I'm on the fence, but given its low utility and the ease of reinstalling the plugin if desired, I'm leaning toward not bothering.Merging logging changes like #1678 may require applying the
ipython.py
changes from30a597fe18681b (@Exirel's sometimes-unnecessary rebasing strikes again!) to the new package.