Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MODIFY] 커피챗 API 변경 (#462) #463

Open
wants to merge 1 commit into
base: dev
Choose a base branch
from
Open

[MODIFY] 커피챗 API 변경 (#462) #463

wants to merge 1 commit into from

Conversation

rlarlgnszx
Copy link
Contributor

📝 PR Summary

🌴 Works

  • API 변경
  • carrer 없는경우 null
  • 현재기수인경우 빼기

🌱 Related Issue

closed #462

🌵 PR 참고사항

@rlarlgnszx rlarlgnszx added the 🔧 Modify 기능 수정 label Nov 30, 2024
@rlarlgnszx rlarlgnszx requested a review from kseysh November 30, 2024 09:45
@rlarlgnszx rlarlgnszx self-assigned this Nov 30, 2024
Copy link

height bot commented Nov 30, 2024

Link Height tasks by mentioning a task ID in the pull request title or commit messages, or description and comments with the keyword link (e.g. "Link T-123").

💡Tip: You can also use "Close T-X" to automatically close a task when the pull request is merged.

Copy link
Member

@kseysh kseysh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

고생하셨습니다~

@@ -222,10 +223,12 @@ public List<CoffeeChatResponse> getCoffeeChatList(String accessToken) {
Map<String, String> headers = PlaygroundHeaderCreator.createAuthorizationHeaderByUserPlaygroundToken(accessToken);
return playgroundClient.getCoffeeChatList(headers).coffeeChatList().stream()
.filter(member -> !member.isBlind())
.map(CoffeeChatResponse::of)
.map(i -> CoffeeChatResponse.of(i, getCurrentActivity(i)))
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P3. i 말고 더 명확한 변수명 사용해주시면 좋을 것 같아요!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[MODIFY] 커피챗 유저 API 수정
2 participants