Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: bottomsheetselect를 portal로 렌더링 #1722

Merged
merged 1 commit into from
Jan 14, 2025
Merged

fix: bottomsheetselect를 portal로 렌더링 #1722

merged 1 commit into from
Jan 14, 2025

Conversation

simeunseo
Copy link
Member

@simeunseo simeunseo commented Jan 14, 2025

🤫 쉿, 나한테만 말해줘요. 이슈넘버

🧐 어떤 것을 변경했어요~?

BottomSheetSelect가 가로스크롤 내에서 사용될 경우 스크롤 영역에 갇혀 보이지 않는 문제가 발생했습니다.
따라서 바텀시트를 <Portal/>을 이용해 portal에서 렌더링되도록 수정하였습니다.

🤔 그렇다면, 어떻게 구현했어요~?

❤️‍🔥 당신이 생각하는 PR포인트, 내겐 매력포인트.

📸 스크린샷, 없으면 이것 참,, 섭섭한데요?

@simeunseo simeunseo added the 🐛 Bug 버그픽스 label Jan 14, 2025
@simeunseo simeunseo self-assigned this Jan 14, 2025
Copy link

height bot commented Jan 14, 2025

Link Height tasks by mentioning a task ID in the pull request title or commit messages, or description and comments with the keyword link (e.g. "Link T-123").

💡Tip: You can also use "Close T-X" to automatically close a task when the pull request is merged.

Copy link

✨✨ 스토리북으로 확인하기 ✨✨

Copy link

🚀 프리뷰 배포 확인하기 🚀

https://675a41e6.sopt-internal-dev.pages.dev

@simeunseo simeunseo added this pull request to the merge queue Jan 14, 2025
Merged via the queue into main with commit 324cff2 Jan 14, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

fix: 모바일에서 bottomsheet 안뜨는 오류
2 participants