This repository has been archived by the owner on May 23, 2022. It is now read-only.
Windows support #16
Closed
Windows support #16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| var killFunction; | ||
|
|
||
| if(os.platform().indexOf('win') !== -1){ | ||
| processes = shell('for /f "tokens=2 delims=," %F in (\'tasklist /nh /fi "imagename eq ' + (processName.indexOf('.') === -1 ? processName + '.exe' : processName) + '" /fo csv\') do @echo %~F', []); |
There was a problem hiding this comment.
Probably too long, but I can't ask Windows just a list of pids! So this single-line command will both ask for process list and translate into pgrep style.. without messing the remaining code just for Windows sake!
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi, this resolves #15
I tested on Windows 8.1 (both cmd.exe and powershell.exe) and worked fine...even killing multiple process (such as chrome), I also tested on Linux Debian 8 and was doing great too after changes.
I tried to not be intrusive changing a lot of code right now 😄 , so I only included an "if" to check OS, but if you think that's OK, I can open another issue to work on mac/osx too.. however it would change a lot of code (and maybe your time, because I'm not too familiar with this Haskell/functional coding style!), Thanks!