Skip to content

Commit

Permalink
Remove faulty director readiness probe & support sorry cypress 1.1.0 (#…
Browse files Browse the repository at this point in the history
…64)

* Remove readiness probe for director

* Support sorry-cypress v1.1.0

* Tweak some ci stuff
  • Loading branch information
tico24 authored Jul 28, 2021
1 parent 5cf940a commit 63340af
Show file tree
Hide file tree
Showing 4 changed files with 5 additions and 13 deletions.
4 changes: 2 additions & 2 deletions .github/workflows/lint-test.yml
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ jobs:
- "kindest/node:v1.19.11"
- "kindest/node:v1.18.19"
- "kindest/node:v1.17.17"
fail-fast: false
fail-fast: true

steps:
- name: Checkout
Expand Down Expand Up @@ -57,7 +57,7 @@ jobs:
run: ct lint --all --debug --config lint.yaml

- name: Create kind cluster
uses: helm/kind-action@v1.1.0
uses: helm/kind-action@v1.2.0
if: steps.list-changed.outputs.changed == 'true'
with:
node_image: ${{ matrix.kubernetes_version }}
Expand Down
4 changes: 2 additions & 2 deletions charts/sorry-cypress/Chart.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -2,8 +2,8 @@ apiVersion: v2
name: sorry-cypress
description: A Helm chart for Sorry Cypress
type: application
version: 1.0.3
appVersion: 1.0.3
version: 1.0.4
appVersion: 1.1.0
home: https://sorry-cypress.dev/
sources:
- https://github.com/sorry-cypress/sorry-cypress
Expand Down
8 changes: 0 additions & 8 deletions charts/sorry-cypress/templates/deployment-director.yml
Original file line number Diff line number Diff line change
Expand Up @@ -98,14 +98,6 @@ spec:
name: {{ include "sorry-cypress-helm.fullname" . }}-director
ports:
- containerPort: 1234
readinessProbe:
httpGet:
path: /
port: 1234
periodSeconds: 10
timeoutSeconds: 5
successThreshold: 2
failureThreshold: 5
resources:
{{- toYaml .Values.director.resources | nindent 10 }}
restartPolicy: Always
Expand Down
2 changes: 1 addition & 1 deletion test.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -6,4 +6,4 @@ chart-repos:
- mongodb=https://charts.bitnami.com/bitnami
chart-dirs:
- charts
helm-extra-args: --timeout 600s
helm-extra-args: --timeout 300s

0 comments on commit 63340af

Please sign in to comment.