Skip to content

Commit

Permalink
Moved serviceAccountName to values (#75)
Browse files Browse the repository at this point in the history
* Moved serviceAccountName to values

Co-authored-by: Konkolowicz <[email protected]>
  • Loading branch information
mkonkolowicz and Konkolowicz authored Oct 21, 2021
1 parent 531c3fc commit c1d989f
Show file tree
Hide file tree
Showing 4 changed files with 6 additions and 2 deletions.
2 changes: 1 addition & 1 deletion charts/sorry-cypress/Chart.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ apiVersion: v2
name: sorry-cypress
description: A Helm chart for Sorry Cypress
type: application
version: 1.1.0
version: 1.1.1
appVersion: 1.1.1
home: https://sorry-cypress.dev/
sources:
Expand Down
1 change: 1 addition & 0 deletions charts/sorry-cypress/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -124,6 +124,7 @@ https://sorry-cypress.dev/director/configuration

| Parameter | Description | Default |
|---------------------------------------------------|------------------------------------------------------------------------------------------------------------------------------------------------------------------------------|----------------------------------|
| `director.serviceAccountName` | Service account to be assumed by the director
| `director.image.repository` | Image repository | `agoldis/sorry-cypress-director` |
| `director.image.tag` | Image tag | `` |
| `director.image.pullPolicy` | Image pull policy | `Always` |
Expand Down
4 changes: 3 additions & 1 deletion charts/sorry-cypress/templates/deployment-director.yml
Original file line number Diff line number Diff line change
Expand Up @@ -109,7 +109,9 @@ spec:
resources:
{{- toYaml .Values.director.resources | nindent 10 }}
restartPolicy: Always
serviceAccountName: ""
{{- with .Values.director.serviceAccountName }}
serviceAccountName: {{ . | quote }}
{{- end }}
volumes: null
{{- if .Values.director.initContainers }}
initContainers:
Expand Down
1 change: 1 addition & 0 deletions charts/sorry-cypress/values.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -131,6 +131,7 @@ dashboard:
# - chart-example.local

director:
serviceAccountName: "default"
image:
repository: agoldis/sorry-cypress-director
pullPolicy: Always
Expand Down

0 comments on commit c1d989f

Please sign in to comment.