Disable the flaky tests for CVC5 #473
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
the flaky tests seem to have gotten worse after the recent update to CVC5. I would suggest disabling
TimoutTestandSolverConcurrencyTestentirely for CVC5 to temporarily fix the issue. The concurrency issues with CVC5 are well known and have already been reported here and here. They seem to be working on a solution, but it will take more time. In the meantime we should have a test-suite that is always green, and once the concurrency problems in CVC5 are resolved the test can easily be turned on again.