Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mzk 41 layout7 cpu #14

Merged
merged 1 commit into from
Sep 16, 2024
Merged

Mzk 41 layout7 cpu #14

merged 1 commit into from
Sep 16, 2024

Conversation

zk-steve
Copy link
Contributor

@zk-steve zk-steve commented Aug 22, 2024

Check List

  • Don't forget to squash commits into meaningful chunks before merging
  • Check every test passed.
  • Did you split imports into std and custom parts?
  • Have you updated the consts in ORN?
  • Have you run ORN with the latest version?
  • Check your commit messages.
  • Have you added meaningful comments?
  • Don't forget to optimize gas cost!
    • Calling vector::length() multiple times is expensive (e.g. in loops), save it to a variable instead.
    • Consider using consts for things that can be pre-computed.
    • pow(2, x) => (1 << x+1)
    • inline short functions to save gas.
    • Find all vector::empty() in all files and replace them with the first append
    • Use vector::*_reverse_*() version to save gas.
  • Check Visibility of functions

This change is Reviewable

Copy link

linear bot commented Aug 22, 2024

MZK-41 Layout7 contracts

@zk-steve
Copy link
Contributor Author

rebase

@0x5ea000000 0x5ea000000 force-pushed the mzk-41-layout7-cpu branch 3 times, most recently from df01e44 to bb9ce38 Compare August 27, 2024 08:49
@zk-steve zk-steve force-pushed the main branch 2 times, most recently from bbe86ed to 4564ca5 Compare August 28, 2024 04:41
Copy link
Contributor Author

@zk-steve zk-steve left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewable status: 0 of 45 files reviewed, 6 unresolved discussions (waiting on @hduoc2003)

public fun fallback(ctx: vector<u256>): u256 {
let res = 0;

let remain = 404 - vector::length(&ctx);
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

4O4 ?

@0x5ea000000 0x5ea000000 merged commit c72c26c into main Sep 16, 2024
1 check passed
@0x5ea000000 0x5ea000000 deleted the mzk-41-layout7-cpu branch September 16, 2024 06:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants