Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Mahjong] Reduce compilation/run time of _pass() #1122

Merged
merged 2 commits into from
Nov 24, 2023
Merged

Conversation

OkanoShinri
Copy link
Collaborator

cf. #1070

@OkanoShinri
Copy link
Collaborator Author

OkanoShinri commented Nov 24, 2023

  • before
function name # expr lines compile time running time
_pass 8539 2526.0ms 223.7μs
  • after
function name # expr lines compile time running time
_pass 7231 2334.7ms 144.3μs

Copy link

codecov bot commented Nov 24, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (674a9d7) 88.08% compared to head (72d9d1f) 88.09%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1122   +/-   ##
=======================================
  Coverage   88.08%   88.09%           
=======================================
  Files          60       60           
  Lines        5918     5922    +4     
=======================================
+ Hits         5213     5217    +4     
  Misses        705      705           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@OkanoShinri
Copy link
Collaborator Author

@sotetsuk
test通ったのでマージして良いですか!

@sotetsuk
Copy link
Owner

お願いします👍🙏@OkanoShinri

@OkanoShinri OkanoShinri merged commit cb470fb into main Nov 24, 2023
4 checks passed
@OkanoShinri OkanoShinri deleted the okano/refactor/pass branch November 24, 2023 16:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants